netdev - Re: [PATCH v2 net] selftests/bpf: fix broken build, take 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170321.185659.980920009946591884.davem@davemloft.net>
Date:   Tue, 21 Mar 2017 18:56:59 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     shuah@...nel.org
Cc:     alexei.starovoitov@...il.com, daniel@...earbox.net,
        zlim.lnx@...il.com, ast@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net] selftests/bpf: fix broken build, take 2

From: Shuah Khan <shuah@...nel.org>
Date: Mon, 20 Mar 2017 10:37:26 -0600

> On 03/20/2017 09:45 AM, Alexei Starovoitov wrote:
>> On Mon, Mar 20, 2017 at 04:31:28PM +0100, Daniel Borkmann wrote:
>>> On 03/20/2017 07:03 AM, Zi Shen Lim wrote:
>>>> Merge of 'linux-kselftest-4.11-rc1':
>>>>
>>>> 1. Partially removed use of 'test_objs' target, breaking force rebuild of
>>>> BPFOBJ, introduced in commit d498f8719a09 ("bpf: Rebuild bpf.o for any
>>>> dependency update").
>>>>
>>>>   Update target so dependency on BPFOBJ is restored.
>>>>
>>>> 2. Introduced commit 2047f1d8ba28 ("selftests: Fix the .c linking rule")
>>>> which fixes order of LDLIBS.
>>>>
>>>>   Commit d02d8986a768 ("bpf: Always test unprivileged programs") added
>>>> libcap dependency into CFLAGS. Use LDLIBS instead to fix linking of
>>>> test_verifier.
>>>>
>>>> 3. Introduced commit d83c3ba0b926 ("selftests: Fix selftests build to
>>>> just build, not run tests").
>>>>
>>>>   Reordering the Makefile allows us to remove the 'all' target.
>>>>
>>>> Tested both:
>>>>     selftests/bpf$ make
>>>> and
>>>>     selftests$ make TARGETS=bpf
>>>> on Ubuntu 16.04.2.
>>>>
>>>> Signed-off-by: Zi Shen Lim <zlim.lnx@...il.com>
>>>
>>> Looks reasonable to me as follow up to 1da8ac7c49fb ("selftests/bpf:
>>> fix broken build"), thanks for fixing Zi!
>>>
>>> Acked-by: Daniel Borkmann <daniel@...earbox.net>
>>> Tested-by: Daniel Borkmann <daniel@...earbox.net>
>> 
>> worked for me as well:
>> Acked-by: Alexei Starovoitov <ast@...nel.org>
>> Tested-by: Alexei Starovoitov <ast@...nel.org>
>> 
>> 
>> 
> 
> David,
> 
> Could you please apply it to your tree. I think you already applied
> the first fix.
> 
> Acked-by: Shuah Khan <shuahkh@....samsung.com>

Done.