netdev - [PATCH] netfilter: ipset: print out warnings generated by commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1490148446-2812-1-git-send-email-vpai@akamai.com>
Date:   Tue, 21 Mar 2017 22:07:26 -0400
From:   Vishwanath Pai <vpai@...mai.com>
To:     pablo@...filter.org, kadlec@...ckhole.kfki.hu
Cc:     johunt@...mai.com, vpai@...mai.com,
        netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
        coreteam@...filter.org, pai.vishwain@...il.com
Subject: [PATCH] netfilter: ipset: print out warnings generated by commands

Warnings are only printed out for IPSET_CMD_TEST. The user won't see
warnings from other commands.

Reviewed-by: Josh Hunt <johunt@...mai.com>
Signed-off-by: Vishwanath Pai <vpai@...mai.com>
---
 src/ipset.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/ipset.c b/src/ipset.c
index 2c4fa10..b0bef7b 100644
--- a/src/ipset.c
+++ b/src/ipset.c
@@ -812,8 +812,8 @@ parse_commandline(int argc, char *argv[])
 			"Unknown argument %s", argv[1]);
 	ret = ipset_cmd(session, cmd, restore_line);
 	D("ret %d", ret);
-	/* Special case for TEST and non-quiet mode */
-	if (cmd == IPSET_CMD_TEST && ipset_session_warning(session)) {
+
+	if (ipset_session_warning(session)) {
 		if (!ipset_envopt_test(session, IPSET_ENV_QUIET))
 			fprintf(stderr, "%s", ipset_session_warning(session));
 		ipset_session_report_reset(session);
-- 
1.9.1