netdev - Re: [PATCH net] sch_dsmark: fix invalid skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170321.172208.1665261530100272388.davem@davemloft.net>
Date:   Tue, 21 Mar 2017 17:22:08 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, stephen@...workplumber.org,
        weiwan@...gle.com
Subject: Re: [PATCH net] sch_dsmark: fix invalid skb_cow() usage

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 17 Mar 2017 08:05:28 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> skb_cow(skb, sizeof(ip header)) is not very helpful in this context.
> 
> First we need to use pskb_may_pull() to make sure the ip header
> is in skb linear part, then use skb_try_make_writable() to
> address clones issues.
> 
> Fixes: 4c30719f4f55 ("[PKT_SCHED] dsmark: handle cloned and non-linear skb's")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable, thanks.