netdev - Re: [PATCH] net: usbnet: support 64bit stats in qmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <99ed5c61-d7d8-82ac-b026-ea4f8bda7dfc@linux-m68k.org>
Date:   Thu, 23 Mar 2017 21:43:41 +1000
From:   Greg Ungerer <gerg@...ux-m68k.org>
To:     Oliver Neukum <oneukum@...e.com>, bjorn@...k.no
Cc:     linux-usb@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net: usbnet: support 64bit stats in qmi_wwan driver

Hi Oliver,

On 23/03/17 18:46, Oliver Neukum wrote:
> Am Donnerstag, den 23.03.2017, 11:25 +1000 schrieb Greg Ungerer:
>> Add support for the net stats64 counters to the usbnet core and then to
>> the qmi_wwan driver.
>>
>> This is a strait forward addition of 64bit counters for RX and TX packets
>> and byte counts. It is done in the same style as for the other net drivers
>> that support stats64.
>>
>> The bulk of the change is to the usbnet core. Then it is trivial to use
>> that in the qmi_wwan.c driver. It would be very simple to extend this
>> support to other usbnet based drivers.
>>
>> The motivation to add this is that it is not particularly difficult to
>> get the RX and TX byte counts to wrap on 32bit platforms.
>
> Hi,
>
> you need to export the symbol usbnet_get_stats64
> Other than that it looks good.

Thanks. I will respin a v2 with that fixed.

Regards
Greg