netdev - Re: [PATCHv2] net: usbnet: support 64bit stats in qmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1490365070.9687.46.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Fri, 24 Mar 2017 07:17:50 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Greg Ungerer <gerg@...ux-m68k.org>
Cc:     bjorn@...k.no, oneukum@...e.com, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCHv2] net: usbnet: support 64bit stats in qmi_wwan driver

On Fri, 2017-03-24 at 15:42 +1000, Greg Ungerer wrote:

> The usbnet core is used by a number of drivers. This patch only
> updates the qmi-wwan driver to use stats64. If you remove the
> dev->stats.rx_* updates all those other driver users will have
> no counts.

I see. Then I guess the u64 stuff could be done only if running 32bit
kernels. (The existing stats are using 'unsigned long' so are already
64bit wide on 64bit kernels)