netdev - Re: [patch net-next] net: sched: atm: destroy main filter chain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170324175540.GA1897@nanopsycho>
Date:   Fri, 24 Mar 2017 18:55:40 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Jamal Hadi Salim <jhs@...atatu.com>, mlxsw@...lanox.com
Subject: Re: [patch net-next] net: sched: atm: destroy main filter chain

Fri, Mar 24, 2017 at 06:46:55PM CET, xiyou.wangcong@...il.com wrote:
>On Fri, Mar 24, 2017 at 6:39 AM, Jiri Pirko <jiri@...nulli.us> wrote:
>> From: Jiri Pirko <jiri@...lanox.com>
>>
>> In atm_tc_destroy, the flow qdisc filter chains are destroyed. However
>> the main chain is not. So fix this memory and reference leak.
>
>Are you sure? 'link' is on the 'flows' already according

Ah. You are correct. Scratch this. Thanks.

Btw, I think that in atm_tc_change:
list_add(&flow->list, &p->link.list);
should be:
list_add(&flow->list, &p->flows);



>to this comment:
>
>struct atm_qdisc_data {
>        struct atm_flow_data    link;           /* unclassified skbs go here */
>        struct list_head        flows;          /* NB: "link" is also on this
>                                                   list */
>        struct tasklet_struct   task;           /* dequeue tasklet */
>};