netdev - Re: [PATCH net] r8152: prevent the driver from transmitting packets with carrier off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170324.123135.1629675630856286721.davem@davemloft.net>
Date:   Fri, 24 Mar 2017 12:31:35 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hayeswang@...ltek.com
Cc:     netdev@...r.kernel.org, nic_swsd@...ltek.com,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH net] r8152: prevent the driver from transmitting
 packets with carrier off

From: Hayes Wang <hayeswang@...ltek.com>
Date: Thu, 23 Mar 2017 19:14:19 +0800

> The linking status may be changed when autosuspend. And, after
> autoresume, the driver may try to transmit packets when the device
> is carrier off, because the interrupt transfer doesn't update the
> linking status, yet. And, if the device is in ALDPS mode, the device
> would stop working.
> 
> The another similar case is
>  1. unplug the cable.
>  2. interrupt transfer queue a work_queue for linking change.
>  3. device enters the ALDPS mode.
>  4. a tx occurs before the work_queue is called.
> 
> Signed-off-by: Hayes Wang <hayeswang@...ltek.com>

Applied.