netdev - Re: [PATCH v2] net: stmmac: add set_mac to the stmmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170324.123652.1821802503059612387.davem@davemloft.net>
Date:   Fri, 24 Mar 2017 12:36:52 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     clabbe.montjoie@...il.com
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: stmmac: add set_mac to the stmmac_ops

From: Corentin Labbe <clabbe.montjoie@...il.com>
Date: Thu, 23 Mar 2017 14:40:22 +0100

> Two different set_mac functions exists but stmmac_dwmac4_set_mac() is
> only used for enabling and never for disabling.
> So on dwmac4, the MAC RX/TX is never disabled.
> 
> This patch add a generic function pointer set_mac() to stmmac_ops and
> replace all call to stmmac_set_mac/stmmac_dwmac4_set_mac by a call to
> this pointer.
> 
> Since dwmac4_ops is const, set_mac cannot be modified after, and so dwmac4_ops
> is duplioacted like dwmac4_dma_ops.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>

Applied.