netdev - Re: [PATCH net-next] liquidio: do not reset Octeon if NIC firmware was preloaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170324.132059.1978744476466250237.davem@davemloft.net>
Date:   Fri, 24 Mar 2017 13:20:59 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     felix.manlunas@...ium.com
Cc:     netdev@...r.kernel.org, raghu.vatsavayi@...ium.com,
        derek.chickles@...ium.com, satananda.burla@...ium.com
Subject: Re: [PATCH net-next] liquidio: do not reset Octeon if NIC firmware
 was preloaded

From: Felix Manlunas <felix.manlunas@...ium.com>
Date: Thu, 23 Mar 2017 13:26:28 -0700

> The PF driver is incorrectly resetting Octeon when the module parameter
> "fw_type=none" is there.  "fw_type=none" means the PF should not load any
> firmware to the NIC because Octeon is already running preloaded firmware.
> 
> Fix it by putting an if (fw_type != none) around the reset code.
> 
> Because the Octeon reset is now conditionally gone, when unloading the
> driver, conditionally send the RESET_PF command to the firmware who will
> then free up PF-related data structures.
> 
> Signed-off-by: Felix Manlunas <felix.manlunas@...ium.com>
> Signed-off-by: Satanand Burla <satananda.burla@...ium.com>

Applied.