netdev - Re: [PATCH] igb: add module param to set max-rss-queues.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <255aaae0-8634-c6b5-f4aa-545d2f717aed@candelatech.com>
Date:   Fri, 24 Mar 2017 14:20:56 -0700
From:   Ben Greear <greearb@...delatech.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] igb: add module param to set max-rss-queues.

On 03/24/2017 02:12 PM, David Miller wrote:
> From: greearb@...delatech.com
> Date: Fri, 24 Mar 2017 13:58:47 -0700
>
>> From: Ben Greear <greearb@...delatech.com>
>>
>> In systems where you may have a very large number of network
>> adapters, certain drivers may consume an unfair amount of
>> IRQ resources.  So, allow a module param that will limit the
>> number of IRQs at driver load time.  This way, other drivers
>> (40G Ethernet, for instance), which probably will need the
>> multiple IRQs more, will not be starved of IRQ resources.
>>
>> Signed-off-by: Ben Greear <greearb@...delatech.com>
>
> Sorry, no module params.
>
> Use generic run-time facilities such as ethtool to configure
> such things.

You cannot call ethtool before module load time, and that is when
the IRQs are first acquired.  It may be way more useful to give each
of 20 network adapters 2 irqs than have the first few grab 16 and the rest
get lumped into legacy crap.

Thanks,
Ben

-- 
Ben Greear <greearb@...delatech.com>
Candela Technologies Inc  http://www.candelatech.com