netdev - Re: [net PATCH] net: Do not allow negative values for busy_read and busy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170324.150238.1364516032866728084.davem@davemloft.net>
Date:   Fri, 24 Mar 2017 15:02:38 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     alexander.duyck@...il.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com
Subject: Re: [net PATCH] net: Do not allow negative values for busy_read
 and busy_poll sysctl interfaces

From: Alexander Duyck <alexander.duyck@...il.com>
Date: Fri, 24 Mar 2017 09:38:03 -0700

> From: Alexander Duyck <alexander.h.duyck@...el.com>
> 
> This change basically codifies what I think was already the limitations on
> the busy_poll and busy_read sysctl interfaces.  We weren't checking the
> lower bounds and as such could input negative values. The behavior when
> that was used was dependent on the architecture. In order to prevent any
> issues with that I am just disabling support for values less than 0 since
> this way we don't have to worry about any odd behaviors.
> 
> By limiting the sysctl values this way it also makes it consistent with how
> we handle the SO_BUSY_POLL socket option since the value appears to be
> reported as a signed integer value and negative values are rejected.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>

Applied, thanks.