netdev - Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170324074255.GB16730@lunn.ch>
Date:   Fri, 24 Mar 2017 08:42:55 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Joao Pinto <Joao.Pinto@...opsys.com>
Cc:     Thierry Reding <thierry.reding@...il.com>, davem@...emloft.net,
        peppe.cavallaro@...com, alexandre.torgue@...com,
        f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

On Thu, Mar 23, 2017 at 05:27:08PM +0000, Joao Pinto wrote:

> Yes, you are correct. It should be priv->plat->tx_queues_to_use instead of "u32
> tx_count = priv->dma_cap.number_tx_queues;"... sorry for that, but in my setup
> is the same value. Could you please make a patch for it?

Hi Joao

As the new maintainer, don't you think you should be testing on
multiple systems? There are SoC vendor reference design boards you can
buy, and set up a test farm. You can then ensure your new features
don't break stuff, or add performance regressions.

      Andrew