netdev - Re: [PATCH net] ping: implement proper locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170324.191016.1704224805339195329.davem@davemloft.net>
Date:   Fri, 24 Mar 2017 19:10:16 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, solar@...nwall.com, andreyknvl@...gle.com,
        edumazet@...gle.com
Subject: Re: [PATCH net] ping: implement proper locking

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 24 Mar 2017 16:29:45 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> We got a report of yet another bug in ping
> 
> http://www.openwall.com/lists/oss-security/2017/03/24/6
> 
> ->disconnect() is not called with socket lock held.
> 
> Fix this by acquiring ping rwlock earlier.
> 
> Thanks to Alexander and Andrey for letting us know of this problem.
> 
> Fixes: c319b4d76b9e ("net: ipv4: add IPPROTO_ICMP socket kind")
> Reported-by: Solar Designer <solar@...nwall.com>
> Reported-by: Andrey Konovalov <andreyknvl@...gle.com>

Eric, please add a proper signoff for yourself, and also please
add the following tag:

Reported-by: Daniel Jiang <danieljiang0415@...il.com>

Thank you.