[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20170325.201317.114625190800188227.davem@davemloft.net>
Date: Sat, 25 Mar 2017 20:13:17 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: jonas@...thpole.se
Cc: pablo@...filter.org, netdev@...r.kernel.org, laforge@...monks.org
Subject: Re: [PATCH net-next v5 0/2] GTP SGSN-side tunnel
From: Jonas Bonn <jonas@...thpole.se>
Date: Fri, 24 Mar 2017 23:23:19 +0100
> Changes since v4:
>
> * Respin the series on top of net-next; the conflicts were trivial,
> amounting to just code having been shifted about
Series applied, but you really have to make improvements to your header
postings.
First of all, what is the point of only listing the most recent "v4"
changes entry? Leave every single changes entry in there, it's
history information and useful to people reviewing the series.
Also, this posting also requires that you explain, in detail, at
a high level, what the patch series is doing, how it is doing it,
and why it is doing it that way.
It should be written in a way that a skilled programmer, after
reading it, can probably predict what your patches look like. It
is an assistance to comprehension and understanding of your changes
and an essential part of patch series submission.
Thank you.
Powered by blists - more mailing lists