netdev - Re: [PATCH RFC v2 1/3] net: phy: avoid setting unsupported EEE advertisments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af448c35-218d-a6c9-3c3a-802350285d88@gmail.com>
Date:   Mon, 27 Mar 2017 11:04:28 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Andrew lunn <andrew@...n.ch>
Subject: Re: [PATCH RFC v2 1/3] net: phy: avoid setting unsupported EEE
 advertisments

On 03/27/2017 02:58 AM, Russell King wrote:
> We currently allow userspace to set any EEE advertisments it desires,
> whether or not the PHY supports them.  For example:
> 
>  # ethtool --set-eee eth1 advertise 0xffffffff
>  # ethtool --show-eee eth1
>  EEE Settings for eth1:
>         EEE status: disabled
>         Tx LPI: disabled
>         Supported EEE link modes:  100baseT/Full
>                                    1000baseT/Full
>                                    10000baseT/Full
>         Advertised EEE link modes:  100baseT/Full
>                                     1000baseT/Full
>                                     1000baseKX/Full
>                                     10000baseT/Full
>                                     10000baseKX4/Full
>                                     10000baseKR/Full
> 
> Clearly, this is not sane, we should only allow link modes that are
> supported to be advertised (as we do elsewhere.)  Ensure that we mask
> the MDIO_AN_EEE_ADV value with the capabilities retrieved from the
> MDIO_PCS_EEE_ABLE register.
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian