netdev - Re: [PATCH 1/5] rds: tcp: release the created connection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58D8C7D9.1070509@oracle.com>
Date:   Mon, 27 Mar 2017 16:05:45 +0800
From:   Yanjun Zhu <yanjun.zhu@...cle.com>
To:     Sowmini Varadhan <sowmini.varadhan@...cle.com>
Cc:     santosh.shilimkar@...cle.com, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, rds-devel@....oracle.com,
        junxiao.bi@...cle.com, joe.jin@...cle.com
Subject: Re: [PATCH 1/5] rds: tcp: release the created connection



On 2017/3/27 15:37, Sowmini Varadhan wrote:
> On (03/27/17 03:06), Zhu Yanjun wrote:
>> Date: Mon, 27 Mar 2017 03:06:26 -0400
>> From: Zhu Yanjun <yanjun.zhu@...cle.com>
>> To: yanjun.zhu@...cle.com, santosh.shilimkar@...cle.com,
>>   netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
>>   rds-devel@....oracle.com, junxiao.bi@...cle.com, joe.jin@...cle.com
>> Subject: [PATCH 1/5] rds: tcp: release the created connection
>> X-Mailer: git-send-email 2.7.4
>>
>> When some error occurs, the created connection should be destroyed.
> No please dont do this.
>
> This is the case when there are duelling connections. We want
> to reset the new (accept sock) and leave the old socket in place.
>
> How did you test this? Did you test it with network namespaces?
Sorry. I just made simple test. It seems that it worked well. Would you 
like to show me some test about this patch?

Thanks a lot.
Zhu Yanjun
>
> --Sowmini
>
>
>>   net/rds/tcp_listen.c | 1 +
>>
>> diff --git a/net/rds/tcp_listen.c b/net/rds/tcp_listen.c
>> index 5076788..58aa5bc 100644
>> --- a/net/rds/tcp_listen.c
>> +++ b/net/rds/tcp_listen.c
>> @@ -196,6 +196,7 @@ int rds_tcp_accept_one(struct socket *sock)
>>   rst_nsk:
>>   	/* reset the newly returned accept sock and bail */
>>   	kernel_sock_shutdown(new_sock, SHUT_RDWR);
>> +	rds_conn_destroy(conn);
>>   	ret = 0;
>>   out:
>>   	if (rs_tcp)
>> -- 
>> 2.7.4
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html