lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 27 Mar 2017 10:58:26 +0100
From:   Russell King - ARM Linux <>
To:     Florian Fainelli <>
Cc:     "David S. Miller" <>,
Subject: [PATCH RFC v2 0/3] phylib EEE updates


This series of patches depends on the previous set of changes, and is
therefore net-next material.

While testing the EEE code, I discovered a number of issues:

1. It is possible to enable advertisment of EEE modes which are not
   supported by the hardware.  We omit to check the supported modes
   and mask off those modes that are not supported before writing the
   EEE advertisment register.

2. We need to restart autonegotiation after a change of the EEE
   advertisment, otherwise the link partner does not see the updated
   EEE modes.

3. SGMII connected PHYs are also capable of supporting EEE.

I'm not too sure why we have the test in phylib for the interface mode,
as the list of interface modes that support EEE is likely to increase
(eg, 10G interface modes have provision to support EEE mode.)  I did
think about killing the test, but the older interface modes probably
don't support it.  Any thoughts on what to do about that - maybe the
test should be reversed to exclude those modes which definitely don't
support EEE?

 drivers/net/phy/phy.c | 29 ++++++++++++++++++++++++++---
 1 file changed, 26 insertions(+), 3 deletions(-)

v2: fix "phy_restart_aneg" build error identified by 0-day
RMK's Patch system:
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to

Powered by blists - more mailing lists