netdev - Re: [PATCH 0/5] net/packet: fix multiple overflow issues in ring buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAeHK+yzQaSZghcHCNLMxNx9XvKuLUXPA1oPN7LvUMi4H5fCtA@mail.gmail.com>
Date:   Tue, 28 Mar 2017 17:15:58 +0200
From:   Andrey Konovalov <andreyknvl@...gle.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Craig Gallek <cgallek@...gle.com>,
        Network Development <netdev@...r.kernel.org>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Kostya Serebryany <kcc@...gle.com>
Subject: Re: [PATCH 0/5] net/packet: fix multiple overflow issues in ring buffers

On Tue, Mar 28, 2017 at 5:06 PM, Willem de Bruijn
<willemdebruijn.kernel@...il.com> wrote:
> On Tue, Mar 28, 2017 at 10:00 AM, Andrey Konovalov
> <andreyknvl@...gle.com> wrote:
>> This patchset addresses multiple overflows and signedness-related issues
>> in packet socket ring buffers.
>>
>> Andrey Konovalov (5):
>>   net/packet: fix overflow in check for priv area size
>>   net/packet: add explicit checks for tp_frame_size
>>   net/packet: fix overflow in check for tp_frame_nr
>>   net/packet: fix overflow in check for tp_reserve
>>   net/packet: reorder checks for ring buffer parameters
>
> These are a lot of changes to backport to stable kernels.
>
> Can we separate the minimal patch set needed to address known overflow
> to send to net (with annotation [PATCH net]) and follow up with the larger
> cleanup to net-next.

Sure, I can put patches 2 and 5 to a separate patchset.

>
>>
>>  net/packet/af_packet.c | 31 +++++++++++++++++++++----------
>>  1 file changed, 21 insertions(+), 10 deletions(-)
>>
>> --
>> 2.12.2.564.g063fe858b8-goog
>>