netdev - Re: [PATCH net] openvswitch: Fix refcount leak on force commit.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPWQB7Ei6KSn2kpxcaBuSqT3=1xrk3ADXKCRCx_6i4i2uh58uQ@mail.gmail.com>
Date:   Tue, 28 Mar 2017 12:26:02 -0700
From:   Joe Stringer <joe@....org>
To:     Jarno Rajahalme <jarno@....org>
Cc:     netdev <netdev@...r.kernel.org>, pravin shelar <pshelar@....org>
Subject: Re: [PATCH net] openvswitch: Fix refcount leak on force commit.

On 28 March 2017 at 11:25, Jarno Rajahalme <jarno@....org> wrote:
> The reference count held for skb needs to be released when the skb's
> nfct pointer is cleared regardless of if nf_ct_delete() is called or
> not.
>
> Failing to release the skb's reference cound led to deferred conntrack
> cleanup spinning forever within nf_conntrack_cleanup_net_list() when
> cleaning up a network namespace:
>
>    kworker/u16:0-19025 [004] 45981067.173642: sched_switch: kworker/u16:0:19025 [120] R ==> rcu_preempt:7 [120]
>    kworker/u16:0-19025 [004] 45981067.173651: kernel_stack: <stack trace>
> => ___preempt_schedule (ffffffffa001ed36)
> => _raw_spin_unlock_bh (ffffffffa0713290)
> => nf_ct_iterate_cleanup (ffffffffc00a4454)
> => nf_conntrack_cleanup_net_list (ffffffffc00a5e1e)
> => nf_conntrack_pernet_exit (ffffffffc00a63dd)
> => ops_exit_list.isra.1 (ffffffffa06075f3)
> => cleanup_net (ffffffffa0607df0)
> => process_one_work (ffffffffa0084c31)
> => worker_thread (ffffffffa008592b)
> => kthread (ffffffffa008bee2)
> => ret_from_fork (ffffffffa071b67c)
>
> Fixes: dd41d33f0b03 ("openvswitch: Add force commit.")
> Reported-by: Yang Song <yangsong@...are.com>
> Signed-off-by: Jarno Rajahalme <jarno@....org>

Thanks for the fix.

Acked-by: Joe Stringer <joe@....org>