netdev - Re: [PATCH net-next 1/2] net: break include loop netdevice.h, dsa.h, devlink.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <224a8890-5eaa-34cf-107b-70718a9c37e5@gmail.com>
Date:   Tue, 28 Mar 2017 15:04:30 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>, sfrench@...ba.org,
        linux-cifs@...r.kernel.org,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Subject: Re: [PATCH net-next 1/2] net: break include loop netdevice.h, dsa.h,
 devlink.h

On 03/28/2017 02:45 PM, Andrew Lunn wrote:
> There is an include loop between netdevice.h, dsa.h, devlink.h because
> of NETDEV_ALIGN, making it impossible to use devlink structures in
> dsa.h.
> 
> Break this loop by taking dsa.h out of netdevice.h, add a forward
> declaration of dsa_switch_tree and netdev_set_default_ethtool_ops()
> function, which is what netdevice.h requires.
> 
> No longer having dsa.h in netdevice.h means the includes in dsa.h no
> longer get included. This breaks a few other files which depend on
> these includes. Add these directly in the affected file.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Woah, thanks for doing this!

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
--
Florian