netdev - Re: [patch net-next 0/8] Add support for pipeline debug (dpipe)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170328065111.GA1873@nanopsycho.orion>
Date:   Tue, 28 Mar 2017 08:51:11 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, arkadis@...lanox.com, idosch@...lanox.com,
        mlxsw@...lanox.com, jhs@...atatu.com, ivecera@...hat.com,
        roopa@...ulusnetworks.com, f.fainelli@...il.com,
        vivien.didelot@...oirfairelinux.com, john.fastabend@...il.com,
        andrew@...n.ch, simon.horman@...ronome.com
Subject: Re: [patch net-next 0/8] Add support for pipeline debug (dpipe)

Tue, Mar 28, 2017 at 12:48:34AM CEST, davem@...emloft.net wrote:
>
>Please fix up these warnings and resubmit:
>
>drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c: In function ‘mlxsw_sp_rif_counter_free’:
>drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:208:2: warning: ‘p_counter_index’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>  mlxsw_sp_rif_counter_edit(mlxsw_sp, rif->rif_index,
>  ^
>drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c: In function ‘mlxsw_sp_table_erif_entries_dump’:
>drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:220:9: warning: missing braces around initializer [-Wmissing-braces]
>  struct devlink_dpipe_value match_value = {0}, action_value = {0};

I know about this warning. I believe that it is a gcc bug. It happens
for gcc 4, but gcc 6 is silent, therefore I choose to ignore this. Do
you still want me to fix it?


>         ^
>drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:220:9: warning: (near initialization for ‘match_value.<anonymous>’) [-Wmissing-braces]
>drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:220:9: warning: missing braces around initializer [-Wmissing-braces]
>drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c:220:9: warning: (near initialization for ‘action_value.<anonymous>’) [-Wmissing-braces]