netdev - RE: [PATCHv2 net] sctp: change to save MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6DCFFBAA9C@AcuExch.aculab.com>
Date:   Tue, 28 Mar 2017 10:12:34 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Xin Long' <lucien.xin@...il.com>,
        network dev <netdev@...r.kernel.org>,
        "linux-sctp@...r.kernel.org" <linux-sctp@...r.kernel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Neil Horman <nhorman@...driver.com>
Subject: RE: [PATCHv2 net] sctp: change to save MSG_MORE flag into assoc

> -----Original Message-----
> From: Xin Long [mailto:lucien.xin@...il.com]
> Sent: 26 March 2017 17:21
> To: network dev; linux-sctp@...r.kernel.org
> Cc: davem@...emloft.net; Marcelo Ricardo Leitner; Neil Horman; David Laight
> Subject: [PATCHv2 net] sctp: change to save MSG_MORE flag into assoc
> 
> David Laight noticed the support for MSG_MORE with datamsg->force_delay
> didn't really work as we expected, as the first msg with MSG_MORE set
> would always block the following chunks' dequeuing.
> 
> This Patch is to rewrite it by saving the MSG_MORE flag into assoc as
> David Laight suggested.
> 
> asoc->force_delay is used to save MSG_MORE flag before a msg is sent.
> All chunks in queue would not be sent out if asoc->force_delay is set
> by the msg with MSG_MORE flag, until a new msg without MSG_MORE flag
> clears asoc->force_delay.
> 
> Note that this change would not affect the flush is generated by other
> triggers, like asoc->state != ESTABLISHED, queue size > pmtu etc.
> 
> v1->v2:
>   Not clear asoc->force_delay after sending the msg with MSG_MORE flag.
> 
> Fixes: 4ea0c32f5f42 ("sctp: add support for MSG_MORE")
> Signed-off-by: Xin Long <lucien.xin@...il.com>
> ---

Acked-by: David Laight <david.laight@...lab.com>

I'll get around to testing it yet :-)

	David