netdev - Re: [PATCH] tcp: possible race between tcp_done() and tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Mar 2017 14:57:49 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Seiichi Ikarashi <s.ikarashi@...fujitsu.com>,
        netdev@...r.kernel.org
Subject: Re: [PATCH] tcp: possible race between tcp_done() and tcp_poll()

Hello!

On 3/29/2017 8:22 AM, Seiichi Ikarashi wrote:

> Similar to commit a4d258036ed9b2a1811.

    Commit citing is standardized: it should specify 12-digit (at least) SHA1 
and the commit summary line enclosed in ("").

> Between receiving a packet and tcp_poll(), sk->sk_err is protected by memory barriers but
> sk->sk_shutdown and sk->sk_state are not. So possibly, POLLIN|POLLRDNORM|POLLRDHUP might
> not be set even when receiving a RST packet.
>
> Signed-off-by: Seiichi Ikarashi <s.ikarashi@...fujitsu.com>
>

     Should be --- before the diffstat.

>  net/ipv4/tcp.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

[...]

MBR, Sergei