netdev - Re: [PATCH net-next v6 01/11] bpf: Add eBPF program subtype and is_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201703292120.wrm0eHSI%fengguang.wu@intel.com>
Date:   Wed, 29 Mar 2017 21:48:01 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Mickaël Salaün <mic@...ikod.net>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        Mickaël Salaün <mic@...ikod.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Andy Lutomirski <luto@...capital.net>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Casey Schaufler <casey@...aufler-ca.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        David Drysdale <drysdale@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        "Eric W . Biederman" <ebiederm@...ssion.com>,
        James Morris <james.l.morris@...cle.com>,
        Jann Horn <jann@...jh.net>, Jonathan Corbet <corbet@....net>,
        Matthew Garrett <mjg59@...f.ucam.org>,
        Michael Kerrisk <mtk.manpages@...il.com>,
        Kees Cook <keescook@...omium.org>,
        Paul Moore <paul@...l-moore.com>,
        Sargun Dhillon <sargun@...gun.me>,
        "Serge E . Hallyn" <serge@...lyn.com>,
        Shuah Khan <shuah@...nel.org>, Tejun Heo <tj@...nel.org>,
        Thomas Graf <tgraf@...g.ch>, Will Drewry <wad@...omium.org>,
        kernel-hardening@...ts.openwall.com, linux-api@...r.kernel.org,
        linux-security-module@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v6 01/11] bpf: Add eBPF program subtype and
 is_valid_subtype() verifier

Hi Mickaël,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Micka-l-Sala-n/Landlock-LSM-Toward-unprivileged-sandboxing/20170329-211258
config: i386-randconfig-x002-201713 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   kernel/bpf/syscall.c: In function 'bpf_prog_load':
>> kernel/bpf/syscall.c:886:25: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
      size = check_user_buf((void __user *)attr->prog_subtype,
                            ^

vim +886 kernel/bpf/syscall.c

   870	
   871		prog->orig_prog = NULL;
   872		prog->jited = 0;
   873	
   874		atomic_set(&prog->aux->refcnt, 1);
   875		prog->gpl_compatible = is_gpl ? 1 : 0;
   876	
   877		/* find program type: socket_filter vs tracing_filter */
   878		err = find_prog_type(type, prog);
   879		if (err < 0)
   880			goto free_prog;
   881	
   882		/* copy eBPF program subtype from user space */
   883		if (attr->prog_subtype) {
   884			__u32 size;
   885	
 > 886			size = check_user_buf((void __user *)attr->prog_subtype,
   887					      attr->prog_subtype_size,
   888					      sizeof(prog->subtype));
   889			if (size < 0) {
   890				err = size;
   891				goto free_prog;
   892			}
   893			/* prog->subtype is __GFP_ZERO */
   894			if (copy_from_user(&prog->subtype,

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (23016 bytes)