netdev - Re: [PATCH] Add checks for kmalloc allocation failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1490804511.24891.37.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Wed, 29 Mar 2017 09:21:51 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Harry Morris <h.morris@...coda.com>, linuxdev@...coda.com,
        Alexander Aring <aar@...gutronix.de>,
        Stefan Schmidt <stefan@....samsung.com>,
        linux-wpan@...r.kernel.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add checks for kmalloc allocation failures

On Wed, 2017-03-29 at 16:54 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Ensure we don't end up with a null pointer dereferences by checking
> for for allocation failures.  Allocate by sizeof(*ptr) rather than
> the type to fix checkpack warnings.  Also merge multiple lines into
> one line for the kmalloc call.
> 
> Detected by CoverityScan, CID#1422435 ("Dereference null return value")

OK, but could you change patch title to be less generic ?

Also, what tree is this patch targeting ?

# ls -l drivers/net/ieee802154/ca8210.c 
ls: cannot access drivers/net/ieee802154/ca8210.c: No such file or
directory

Thanks.