netdev - Re: [PATCH net-next 2/2] net: dsa: dsa2: Add basic support of devlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170329173624.GE7942@lunn.ch>
Date:   Wed, 29 Mar 2017 19:36:24 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>, sfrench@...ba.org,
        linux-cifs@...r.kernel.org,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Subject: Re: [PATCH net-next 2/2] net: dsa: dsa2: Add basic support of devlink

> Tangential question: we do not currently report to user space what kind
> of switch tagging protocol is used (DSA, eDSA etc.) I was going to add a
> sysfs attribute for that under the switch device's directory, but maybe
> devlink would be more appropriate for that?

We don't report it. What are you thinking you want to do with this
information?

I suppose it might be possible to teach libpcap/tcpdump about it, so
it can slide in an additional dissector. EDSA you can detect anyway,
since it uses a well know Ethertype. tcpdump already supports
this. But the other tag protocols cannot be detected.

devlink does seem like a good candidate for this, make it part of the
port type.

     Andrew