netdev - Re: [PATCH] ezchip: nps_enet: check if napi has been completed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJ1+7CrF=hJj-_pLWV+EDXxhUZGOL+3je6zjE8dJDcr=A@mail.gmail.com>
Date:   Wed, 29 Mar 2017 14:41:40 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     David Miller <davem@...emloft.net>
Cc:     Vladislav.Zakharov@...opsys.com, netdev <netdev@...r.kernel.org>,
        eladkan@...lanox.com, noamca@...lanox.com,
        LKML <linux-kernel@...r.kernel.org>,
        linux-snps-arc@...ts.infradead.org
Subject: Re: [PATCH] ezchip: nps_enet: check if napi has been completed

On Wed, Mar 29, 2017 at 2:30 PM, David Miller <davem@...emloft.net> wrote:
Signed-off-by: Vlad Zakharov <vzakhar@...opsys.com>
>
> Applied.
>
> Eric, if this is really required now, we have 148 broken drivers still.

Piece of cake :/

If we get more reports like that, we might implement a logic to
prevent infinite loops.

It is not clear to me what exactly happened to this driver, since
testing napi_complete_done() was not mandatory.