netdev - Re: [PATCH net] ftgmac100: Mostly rewrite the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1490763787.3177.168.camel@kernel.crashing.org>
Date:   Wed, 29 Mar 2017 16:03:07 +1100
From:   Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] ftgmac100: Mostly rewrite the driver

On Tue, 2017-03-28 at 21:57 -0700, David Miller wrote:
> This is unreviewable.
> 
> You must break this up into small, reviewable pieces.
> 
> If you didn't save the steps of your work in that way, that isn't
> our problem.

That's not realistic, it would probably not improve the readability
much. I basically ended up rewriting the driver almost completely
Dave. It's not even a matter of saving my work steps, each of them
involved pulling appart an entire side of the old driver and re-doing
it. 

That's why I said it's better reviewed as a new driver. We have no
other user of it in the tree anyway.

Do you prefer that I submit it as a new driver for that IP block
instead and take out the old one later ?

Cheers,
Ben.