netdev - Re: [PATCH, net] isdn: kcapi: avoid uninitialized data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170328.175944.544884009543869614.davem@davemloft.net>
Date:   Tue, 28 Mar 2017 17:59:44 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     isdn@...ux-pingi.de, mingo@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH, net] isdn: kcapi: avoid uninitialized data

From: Arnd Bergmann <arnd@...db.de>
Date: Tue, 28 Mar 2017 12:11:07 +0200

> gcc-7 points out that the AVMB1_ADDCARD ioctl results in an unintialized
> value ending up in the cardnr parameter:
> 
> drivers/isdn/capi/kcapi.c: In function 'old_capi_manufacturer':
> drivers/isdn/capi/kcapi.c:1042:24: error: 'cdef.cardnr' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>    cparams.cardnr = cdef.cardnr;
> 
> This has been broken since before the start of the git history, so
> either the value is not used for anything important, or the ioctl
> command doesn't get called in practice.
> 
> Setting the cardnr to zero avoids the warning and makes sure
> we have consistent behavior.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.