netdev - Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170330143435.GA28098@ulmo.ba.sec>
Date:   Thu, 30 Mar 2017 16:34:36 +0200
From:   Thierry Reding <treding@...dia.com>
To:     Corentin Labbe <clabbe.montjoie@...il.com>
CC:     David Miller <davem@...emloft.net>, <arnd@...db.de>,
        <peppe.cavallaro@...com>, <alexandre.torgue@...com>,
        <Joao.Pinto@...opsys.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote:
> On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> > Date: Tue, 28 Mar 2017 11:48:21 +0200
> > 
> > > A driver must not access the two fields directly but should instead use
> > > the helper functions to set the values and keep a consistent internal
> > > state:
> > > 
> > > ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_dvr_probe':
> > > ethernet/stmicro/stmmac/stmmac_main.c:4083:8: error: 'struct net_device' has no member named 'real_num_rx_queues'; did you mean 'real_num_tx_queues'?
> > > 
> > > Fixes: a8f5102af2a7 ("net: stmmac: TX and RX queue priority configuration")
> > > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > 
> > Applied.
> 
> This break my revert patch. (since it patch ("net: stmmac: enable multiple buffers").
> Since dwmac-sunxi is still broken, what can I do ? send two revert patch ? or adapt the reverting patch.

Have you tried if the kcalloc() patch I sent on Tuesday fixes things the
issues introduced by the multiple buffers patch? Niklas reported that it
restores functionality on his setup.

If it makes things work for you as well, we could maybe avoid the revert
altogether.

You can find the patch here:

	https://patchwork.ozlabs.org/patch/744286/

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)