netdev - Re: [PATCH] r8152: The Microsoft Surface docks also use R8152.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1490893565.24247.9.camel@redhat.com>
Date:   Thu, 30 Mar 2017 12:06:05 -0500
From:   Dan Williams <dcbw@...hat.com>
To:     Rene Rebe <rene@...ctcode.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, nic_swsd@...ltek.com
Subject: Re: [PATCH] r8152: The Microsoft Surface docks also use R8152.

On Tue, 2017-03-28 at 06:42 +0200, Rene Rebe wrote:
> Without this the generic cdc_ether grabs the device,
> and does not really work.

Does this need a corresponding blacklist in cdc_ether then?  Otherwise
you're really depending on driver loading order.

Dan

> Signed-off-by: René Rebe <rene@...ctcode.com>
> 
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index c34df33..07f788c 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -517,6 +517,7 @@ enum rtl8152_flags {
>  
>  /* Define these values to match your device */
>  #define VENDOR_ID_REALTEK              0x0bda
> +#define VENDOR_ID_MICROSOFT            0x045e
>  #define VENDOR_ID_SAMSUNG              0x04e8
>  #define VENDOR_ID_LENOVO               0x17ef
>  #define VENDOR_ID_NVIDIA               0x0955
> @@ -4521,6 +4522,8 @@ static void rtl8152_disconnect(struct
> usb_interface *intf)
>  static struct usb_device_id rtl8152_table[] = {
>         {REALTEK_USB_DEVICE(VENDOR_ID_REALTEK, 0x8152)},
>         {REALTEK_USB_DEVICE(VENDOR_ID_REALTEK, 0x8153)},
> +       {REALTEK_USB_DEVICE(VENDOR_ID_MICROSOFT, 0x07ab)},
> +       {REALTEK_USB_DEVICE(VENDOR_ID_MICROSOFT, 0x07c6)},
>         {REALTEK_USB_DEVICE(VENDOR_ID_SAMSUNG, 0xa101)},
>         {REALTEK_USB_DEVICE(VENDOR_ID_LENOVO,  0x304f)},
>         {REALTEK_USB_DEVICE(VENDOR_ID_LENOVO,  0x3062)},
> 
> 
> -- 
>   René Rebe, ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin
>   http://exactcode.com | http://t2-project.org | http://rene.rebe.de