netdev - Re: [PATCH] virtio_net: fix mergeable bufs error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170330.105706.320793115840611639.davem@davemloft.net>
Date:   Thu, 30 Mar 2017 10:57:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mst@...hat.com
Cc:     linux-kernel@...r.kernel.org, john.fastabend@...il.com,
        jasowang@...hat.com, virtualization@...ts.linux-foundation.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] virtio_net: fix mergeable bufs error handling

From: "Michael S. Tsirkin" <mst@...hat.com>
Date: Wed, 29 Mar 2017 15:37:37 +0300

> @@ -570,7 +570,7 @@ static struct sk_buff *receive_mergeable(struct net_device *dev,
>  	u16 num_buf;
>  	struct page *page;
>  	int offset;
> -	struct sk_buff *head_skb, *curr_skb;
> +	struct sk_buff *head_skb = NULL, *curr_skb;
>  	struct bpf_prog *xdp_prog;
>  	unsigned int truesize;
>  

Like Jason, I see the very next line is:

	head_skb = NULL;

so I don't think this is necessary.