lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Mar 2017 13:02:21 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Roger Quadros <rogerq@...com> Cc: andrew@...n.ch, davem@...emloft.net, kyle.roeschley@...com, nsekhar@...com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, "stable # v4 . 9+" <stable@...r.kernel.org>, Sergei Shtylyov <sergei.shtylyov@...entembedded.com> Subject: Re: [PATCH v3 1/2] net: phy: Fix PHY AN done state machine for interrupt driven PHYs On 03/27/2017 04:59 AM, Roger Quadros wrote: > The Ethernet link on an interrupt driven PHY was not coming up if the > Ethernet cable was plugged before the Ethernet interface was brought up. > > The PHY state machine seems to be stuck from RUNNING to AN state > with no new interrupts from the PHY. So it doesn't know when the > PHY Auto-negotiation has been completed and doesn't transition to RUNNING > state with ANEG done thus netif_carrier_on() is never called. > > NOTE: genphy_config_aneg() will not restart PHY Auto-negotiation of > advertisement parameters didn't change. > > Fix this by scheduling the PHY state machine in phy_start_aneg(). > There is no way of knowing in phy.c whether auto-negotiation was > restarted or not by the PHY driver so we just wait for the next > poll/interrupt to update the PHY state machine. > > Fixes: 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not polling.") > Cc: stable <stable@...r.kernel.org> # v4.9+ > Signed-off-by: Roger Quadros <rogerq@...com> Reviewed-by: Florian Fainelli <f.fainelli@...il.com> -- Florian
Powered by blists - more mailing lists