netdev - Re: [PATCH] r8152: The Microsoft Surface docks also use R8152.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170328.080039.1883015502420058477.rene@exactcode.com>
Date:   Tue, 28 Mar 2017 08:00:39 +0200 (CEST)
From:   Rene Rebe <rene@...ctcode.com>
To:     dcbw@...hat.com
Cc:     davem@...emloft.net, netdev@...r.kernel.org, nic_swsd@...ltek.com
Subject: Re: [PATCH] r8152: The Microsoft Surface docks also use R8152.

> On Thu, 2017-03-30 at 19:47 +0200, René Rebe wrote:
> > Hi,
> > 
> > On Mar 30, 2017, at 19:06, Dan Williams <dcbw@...hat.com> wrote:
> > 
> > > On Tue, 2017-03-28 at 06:42 +0200, Rene Rebe wrote:
> > > > Without this the generic cdc_ether grabs the device,
> > > > and does not really work.
> > > 
> > > Does this need a corresponding blacklist in cdc_ether
> > > then?  Otherwise
> > > you're really depending on driver loading order.
> > 
> > right, I already test build, and will send after reboot.
> > 
> > Any other nitpick in the meantime?
> 
> Nope, other than it's pretty odd that the device would expose standard
> cdc-ether compatible USB descriptors, but apparently not be compatible
> with cdc-ether?  Are we sure we don't just need a tweak or something to
> cdc-ether?

Based on the existing glue and blacklist code I would assume most if
not all R8152 devices have this "issue".

However, sometimes the standard macOS driver works with it. IIRC if
the dock is connected after booting or so, so maybe the BIOS network
boot glue alters the behavior or whatever. It never was able to TX any
packet with the generic Linux cdc-ether, though.

Anyways, given the existing specific Linux driver I would assume it is
better to use it in any case.

       René

-- 
  René Rebe, ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin
  http://exactcode.com | http://t2-project.org | http://rene.rebe.de