netdev - Re: [PATCH] Add checks for kmalloc allocation failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb3689eb-17f7-f971-c635-1bb9e4183ff4@osg.samsung.com>
Date:   Thu, 30 Mar 2017 03:52:42 +0200
From:   Stefan Schmidt <stefan@....samsung.com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        Colin King <colin.king@...onical.com>
Cc:     Harry Morris <h.morris@...coda.com>, linuxdev@...coda.com,
        Alexander Aring <aar@...gutronix.de>,
        linux-wpan@...r.kernel.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add checks for kmalloc allocation failures

Hello.

On 03/29/2017 06:21 PM, Eric Dumazet wrote:
> On Wed, 2017-03-29 at 16:54 +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> Ensure we don't end up with a null pointer dereferences by checking
>> for for allocation failures.  Allocate by sizeof(*ptr) rather than
>> the type to fix checkpack warnings.  Also merge multiple lines into
>> one line for the kmalloc call.
>>
>> Detected by CoverityScan, CID#1422435 ("Dereference null return value")
>
> OK, but could you change patch title to be less generic ?
>
> Also, what tree is this patch targeting ?
>
> # ls -l drivers/net/ieee802154/ca8210.c
> ls: cannot access drivers/net/ieee802154/ca8210.c: No such file or
> directory

This new driver is sitting in bluetooth-next right now for the next merge.

regards
Stefan Schmidt