netdev - Re: [PATCH V2 net-next 18/18] net: hns: Some checkpatch.pl script & warning fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 31 Mar 2017 08:44:57 -0700
From:   Joe Perches <joe@...ches.com>
To:     Salil Mehta <salil.mehta@...wei.com>, davem@...emloft.net
Cc:     yisen.zhuang@...wei.com, mehta.salil.lnk@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linuxarm@...wei.com
Subject: Re: [PATCH V2 net-next 18/18] net: hns: Some checkpatch.pl script &
 warning fixes

On Fri, 2017-03-31 at 12:20 +0100, Salil Mehta wrote:
> This patch fixes some checkpatch.pl script caught errors and
> warnings during the compilation time.
[]
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
[]
> @@ -512,7 +512,8 @@ static void hns_nic_reuse_page(struct sk_buff *skb, int i,
>  	int last_offset;
>  	bool twobufs;
>  
> -	twobufs = ((PAGE_SIZE < 8192) && hnae_buf_size(ring) == HNS_BUFFER_SIZE_2048);
> +	twobufs = ((PAGE_SIZE < 8192) && hnae_buf_size(ring)
> +			== HNS_BUFFER_SIZE_2048);

This would read nicer without splitting a comparison test
onto multiple lines

	twobufs = PAGE_SIZE < 8192 &&
		  hnae_buf_size(ring) == HNS_BUFFER_SIZE_2048;