netdev - Re: [PATCH] ipv4: netfilter: Comparison to NULL could be written

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1491051959.27353.40.camel@perches.com>
Date:   Sat, 01 Apr 2017 06:05:59 -0700
From:   Joe Perches <joe@...ches.com>
To:     Arushi Singhal <arushisinghal19971997@...il.com>,
        pablo@...filter.org
Cc:     Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        "David S. Miller" <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        James Morris <jmorris@...ei.org>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Patrick McHardy <kaber@...sh.net>,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipv4: netfilter: Comparison to NULL could be written

On Sat, 2017-04-01 at 14:05 +0530, Arushi Singhal wrote:
> Fixed coding style for null comparisons to be more
> consistant with the rest of the kernel coding style.

typo: consistent and trivia:

> diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c
[]
> @@ -653,7 +653,7 @@ static struct xt_counters *alloc_counters(const struct xt_table *table)
>  	countersize = sizeof(struct xt_counters) * private->number;
>  	counters = vzalloc(countersize);
>  
> -	if (counters == NULL)
> +	if (!counters)
>  		return ERR_PTR(-ENOMEM);

This could also remove the blank link above the test.