netdev - Re: [PATCH net-next 1/2] rtnetlink: Convert rtnetlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <299c6c86-9a35-f3b6-2658-caad0e6f825f@cumulusnetworks.com>
Date:   Sat, 1 Apr 2017 09:51:56 -0600
From:   David Ahern <dsa@...ulusnetworks.com>
To:     Vladislav Yasevich <vyasevich@...il.com>, netdev@...r.kernel.org
Cc:     roopa@...ulusnetworks.com, davem@...emloft.net,
        Vladislav Yasevich <vyasevic@...hat.com>
Subject: Re: [PATCH net-next 1/2] rtnetlink: Convert rtnetlink_event to white
 list

On 3/31/17 8:27 PM, Vladislav Yasevich wrote:
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index 9c3947a..f48a60d 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -4116,22 +4116,23 @@ static int rtnetlink_event(struct notifier_block *this, unsigned long event, voi
>  	struct net_device *dev = netdev_notifier_info_to_dev(ptr);
>  
>  	switch (event) {
> -	case NETDEV_UP:
> -	case NETDEV_DOWN:
> -	case NETDEV_PRE_UP:
> -	case NETDEV_POST_INIT:
> -	case NETDEV_REGISTER:
> -	case NETDEV_CHANGE:
> -	case NETDEV_PRE_TYPE_CHANGE:
> -	case NETDEV_GOING_DOWN:
> -	case NETDEV_UNREGISTER:
> -	case NETDEV_UNREGISTER_FINAL:
> -	case NETDEV_RELEASE:
> -	case NETDEV_JOIN:
> -	case NETDEV_BONDING_INFO:
> +	case NETDEV_REBOOT:
> +	case NETDEV_CHANGEMTU:
> +	case NETDEV_CHANGENAME:
> +	case NETDEV_FEAT_CHANGE:
> +	case NETDEV_BONDING_FAILOVER:
> +	case NETDEV_NOTIFY_PEERS:
> +	case NETDEV_CHANGEUPPER:
> +	case NETDEV_RESEND_IGMP:
> +	case NETDEV_PRECHANGEMTU:
> +	case NETDEV_CHANGEINFODATA:
> +	case NETDEV_PRECHANGEUPPER:
> +	case NETDEV_CHANGELOWERSTATE:
> +	case NETDEV_UDP_TUNNEL_PUSH_INFO:
> +	case NETDEV_CHANGE_TX_QUEUE_LEN:

missing NETDEV_CHANGEADDR and NETDEV_POST_TYPE_CHANGE

since this patch is just flipping the list type, those should be added here.