netdev - Re: [PATCH net-next] vxlan: vxlan dev should inherit lowerdev's gso_max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170401.114810.576184860484510648.davem@davemloft.net>
Date:   Sat, 01 Apr 2017 11:48:10 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     felix.manlunas@...ium.com
Cc:     netdev@...r.kernel.org, satananda.burla@...ium.com,
        stephen@...workplumber.org
Subject: Re: [PATCH net-next] vxlan: vxlan dev should inherit lowerdev's
 gso_max_size

From: Felix Manlunas <felix.manlunas@...ium.com>
Date: Wed, 29 Mar 2017 17:56:43 -0700

> vxlan dev currently ignores lowerdev's gso_max_size, which adversely
> affects TSO performance of liquidio if it's the lowerdev.  Egress TCP
> packets' skb->len often exceed liquidio's advertised gso_max_size.  This
> may happen on other NIC drivers.
> 
> Fix it by assigning lowerdev's gso_max_size to that of vxlan dev.  Might as
> well do likewise for gso_max_segs.
> 
> Single flow TSO throughput of liquidio as lowerdev (using iperf3):
> 
>     Before the patch:    139 Mbps
>     After the patch :   8.68 Gbps
>     Percent increase:  6,144 %
> 
> Signed-off-by: Felix Manlunas <felix.manlunas@...ium.com>
> Signed-off-by: Satanand Burla <satananda.burla@...ium.com>

Ok, since this location is exactly when we associate the lowerdev
this is the right way to fix this.

Applied, thank you.