netdev - Re: [PATCH net-next 1/2] rds: tcp: allow progress of rds_conn_shutdown if the rds_connection is marked ERROR by an intervening FIN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ad57c65-246e-195c-f76b-6afbb5b9c25e@oracle.com>
Date:   Sat, 1 Apr 2017 11:53:41 -0700
From:   "santosh.shilimkar@...cle.com" <santosh.shilimkar@...cle.com>
To:     Sowmini Varadhan <sowmini.varadhan@...cle.com>,
        netdev@...r.kernel.org
Cc:     davem@...emloft.net
Subject: Re: [PATCH net-next 1/2] rds: tcp: allow progress of
 rds_conn_shutdown if the rds_connection is marked ERROR by an intervening FIN

On 3/31/17 3:56 PM, Sowmini Varadhan wrote:
> rds_conn_shutdown() runs in workq context, and marks the rds_connection
> as DISCONNECTING before quiescing Tx/Rx paths. However, after all I/O
> has quiesced, we may still find the rds_connection state to be
> RDS_CONN_ERROR if an intervening FIN was processed in softirq context.
>
> This is not a fatal error: rds_conn_shutdown() should continue the
> shutdown, and there is no need to log noisy messages about this event.
>
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@...cle.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>