netdev - Re: [PATCH 10/13] ftgmac100: Add a reset task and use it for link changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1491167150.26047.14.camel@kernel.crashing.org>
Date:   Mon, 03 Apr 2017 07:05:50 +1000
From:   Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 10/13] ftgmac100: Add a reset task and use it for link
 changes

On Sun, 2017-04-02 at 20:42 +0200, Andrew Lunn wrote:
> Have you run lockdep tests on this? I think it is normal to take the
> rtnl lock first, then the phydev lock. Try some ethtool operations
> and see if you get a splat.

You are right. I actually realized that was wrong last night ;-) It
will splat with the order in open/close.

Just a stupid thinko (I added the phy lock in a second pass). I'll
fix that.

> Also, do you need to be worried about mdio operations? Do you need to
> take that lock as well, since there might be other PHYs, or an
> Ethernet switch on the bus?

There could be I suppose, none of the setups I've seen with those
SoC has done it but nothing prevents it, I'll have a look.

Thanks.
Ben.