netdev - Re: [PATCH] phy/ethtool: Add missing SPEED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1491169758.27353.50.camel@perches.com>
Date:   Sun, 02 Apr 2017 14:49:18 -0700
From:   Joe Perches <joe@...ches.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] phy/ethtool: Add missing SPEED_<foo> strings

On Sun, 2017-04-02 at 23:40 +0200, Andrew Lunn wrote:
> On Sun, Apr 02, 2017 at 02:30:06PM -0700, Joe Perches wrote:
> > Add all the currently available SPEED_<foo> strings.
[]
> > diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
[]
> > @@ -1487,6 +1487,7 @@ enum ethtool_link_mode_bit_indices {
> >   */
> >  
> >  /* The forced speed, in units of 1Mb. All values 0 to INT_MAX are legal. */
> 
> Hi Joe
> 
> Given that this list is getting longer and longer, and the comment
> that 0..INT_MAX are legal, is it time to replace this with something
> dynamic?

Hey Andrew.

Probably not.

INT_MAX in units of millions is likely large enough for
quite awhile yet, maybe 2 decades or even more.

If you feel ambitious, and remember ethtool.h and
SPEED_<foo> uses are a public API, write something up.

cheers, Joe