netdev - Re: [PATCH -next] liquidio: clear the correct memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170403184020.GA1018@felix-thinkpad.cavium.com>
Date:   Mon, 3 Apr 2017 11:40:20 -0700
From:   Felix Manlunas <felix.manlunas@...ium.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Derek Chickles <derek.chickles@...iumnetworks.com>,
        Prasad Kanneganti <prasad.kanneganti@...ium.com>,
        Satanand Burla <satananda.burla@...iumnetworks.com>,
        Raghu Vatsavayi <raghu.vatsavayi@...iumnetworks.com>,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] liquidio: clear the correct memory

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Mon, 2017-Apr-03 21:18:27 +0300

> There is a cut and paste bug here so we accidentally clear the first
> few bytes of "resp" a second time instead clearing "ctx".
> 
> Fixes: 50c0add534d2 ("liquidio: refactor interrupt moderation code")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
> index fac02ed2c449..dab10c7e4443 100644
> --- a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
> +++ b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
> @@ -1359,7 +1359,7 @@ static int octnet_get_intrmod_cfg(struct lio *lio,
>  	memset(resp, 0, sizeof(struct oct_intrmod_resp));
>  
>  	ctx = (struct oct_intrmod_context *)sc->ctxptr;
> -	memset(resp, 0, sizeof(struct oct_intrmod_context));
> +	memset(ctx, 0, sizeof(struct oct_intrmod_context));
>  	WRITE_ONCE(ctx->cond, 0);
>  	ctx->octeon_id = lio_get_device_id(oct_dev);
>  	init_waitqueue_head(&ctx->wc);

Good catch, Dan.  Thanks.

Acked-by: Felix Manlunas <felix.manlunas@...ium.com>