netdev - Re: [PATCH net] flow dissector: correct size of storage for ARP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170403.144749.510468372321111720.davem@davemloft.net>
Date:   Mon, 03 Apr 2017 14:47:49 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     simon.horman@...ronome.com
Cc:     dinan.gunawardena@...ronome.com, netdev@...r.kernel.org,
        oss-drivers@...ronome.com, nicolas.iooss_linux@....org
Subject: Re: [PATCH net] flow dissector: correct size of storage for ARP

From: Simon Horman <simon.horman@...ronome.com>
Date: Mon,  3 Apr 2017 15:42:58 -0400

> The last argument to __skb_header_pointer() should be a buffer large
> enough to store struct arphdr. This can be a pointer to a struct arphdr
> structure. The code was previously using a pointer to a pointer to
> struct arphdr.
> 
> By my counting the storage available both before and after is 8 bytes on
> x86_64.
> 
> Fixes: 55733350e5e8 ("flow disector: ARP support")
> Reported-by: Nicolas Iooss <nicolas.iooss_linux@....org>
> Signed-off-by: Simon Horman <simon.horman@...ronome.com>

Applied and queued up for -stable.

> this problem is present in both net, since v4.11-rc1 and net-next.
> However, the code has refactored in net-next. I expect this will result
> in a conflict. Let me know if you would like me to post a version for
> net-next too.

I'll sort out the merge hassles into net-next myself, thanks for
letting me know.