netdev - Re: [PATCHv4] net: usbnet: support 64bit stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 03 Apr 2017 10:22:29 +0200
From:   Bjørn Mork <bjorn@...k.no>
To:     Greg Ungerer <gerg@...ux-m68k.org>
Cc:     oneukum@...e.com, netdev@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCHv4] net: usbnet: support 64bit stats

Greg Ungerer <gerg@...ux-m68k.org> writes:

> Add support for the net stats64 counters to the usbnet core. With that
> in place put the hooks into every usbnet driver to use it.
>
> This is a strait forward addition of 64bit counters for RX and TX packet
> and byte counts. It is done in the same style as for the other net drivers
> that support stats64. Note that the other stats fields remain as 32bit
> sized values (error counts, etc).
>
> The motivation to add this is that it is not particularly difficult to
> get the RX and TX byte counts to wrap on 32bit platforms.
>
> Signed-off-by: Greg Ungerer <gerg@...ux-m68k.org>
> ---
>  drivers/net/usb/asix_devices.c    |  3 +++
>  drivers/net/usb/ax88172a.c        |  1 +
>  drivers/net/usb/ax88179_178a.c    |  1 +
>  drivers/net/usb/cdc_mbim.c        |  1 +
>  drivers/net/usb/cdc_ncm.c         |  1 +
>  drivers/net/usb/dm9601.c          |  1 +
>  drivers/net/usb/int51x1.c         |  1 +
>  drivers/net/usb/mcs7830.c         |  1 +
>  drivers/net/usb/qmi_wwan.c        |  1 +
>  drivers/net/usb/rndis_host.c      |  1 +
>  drivers/net/usb/sierra_net.c      |  1 +
>  drivers/net/usb/smsc75xx.c        |  1 +
>  drivers/net/usb/smsc95xx.c        |  1 +
>  drivers/net/usb/sr9700.c          |  1 +
>  drivers/net/usb/sr9800.c          |  1 +
>  drivers/net/usb/usbnet.c          | 55 ++++++++++++++++++++++++++++++++++++---
>  drivers/net/wireless/rndis_wlan.c |  1 +
>  include/linux/usb/usbnet.h        |  4 +++
>  18 files changed, 73 insertions(+), 4 deletions(-)
>
> v2: EXPORT usbnet_get_stats64()
>     rebase on top of net-next
>
> v3: use percpu vars for stats64 counters
>
> v4: update all usbnet drivers to use stats64


Looking good.  For the qmi_wwan part:

Acked-by: Bjørn Mork <bjorn@...k.no>