netdev - Re: Pointer type of _arp in __skb_flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170403084714.GB30894@vergenet.net>
Date:   Mon, 3 Apr 2017 04:47:15 -0400
From:   Simon Horman <simon.horman@...ronome.com>
To:     Nicolas Iooss <nicolas.iooss_linux@....org>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: Pointer type of _arp in __skb_flow_dissect()

Hi Nicolas,

thanks for pointing this out.

On Fri, Mar 31, 2017 at 08:53:10PM +0200, Nicolas Iooss wrote:
> Hello,
> 
> Linux 4.11-rc4 contains the following code in function
> __skb_flow_dissect(), file net/core/flow_dissector.c:
> 
> 	const struct arphdr *arp;
> 	struct arphdr *_arp;

It looks like *_arp should be _arp.
And it looks like this affects net, since v4.11-rc1, and net-next.
I'll test the fix and post a patch unless someone beats me to it.

> 
> 	arp = __skb_header_pointer(skb, nhoff, sizeof(_arp), data,
> 				   hlen, &_arp);
> 
> 
> Here _arp and arp are both pointers to arphdr structures. In other calls
> to __skb_header_pointer(), the buffer argument (_arp here) would have
> been a struct instead of a pointer. What makes ARP packets different in
> __skb_flow_dissect()?
> 
> Thanks,
> Nicolas
> 
> PS: the code which I am curious about seems to have been introduced in
> 4.11-rc1 with commit 55733350e5e8 ("flow disector: ARP support")