netdev - Re: [patch 1/2] drivers/net/ethernet/mellanox/mlx5/core/en

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170402.193326.404525218121744191.davem@davemloft.net>
Date:   Sun, 02 Apr 2017 19:33:26 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     akpm@...ux-foundation.org
Cc:     saeedm@...lanox.com, netdev@...r.kernel.org, tariqt@...lanox.com
Subject: Re: [patch 1/2] drivers/net/ethernet/mellanox/mlx5/core/en_main.c:
 fix build with gcc-4.4.4

From: akpm@...ux-foundation.org
Date: Fri, 31 Mar 2017 13:09:38 -0700

> From: Andrew Morton <akpm@...ux-foundation.org>
> Subject: drivers/net/ethernet/mellanox/mlx5/core/en_main.c: fix build with gcc-4.4.4
> 
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_redirect_rqts':
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:2210: error: unknown field 'rqn' specified in initializer
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:2211: warning: missing braces around initializer
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:2211: warning: (near initialization for 'direct_rrp.<anonymous>')
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_redirect_rqts_to_channels':
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:2227: error: unknown field 'rss' specified in initializer
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:2227: warning: missing braces around initializer
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:2227: warning: (near initialization for 'rrp.<anonymous>')
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:2227: warning: initialization makes integer from pointer without a cast
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:2228: error: unknown field 'rss' specified in initializer
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:2229: warning: excess elements in struct initializer
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:2229: warning: (near initialization for 'rrp')
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_redirect_rqts_to_drop':
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:2238: error: unknown field 'rqn' specified in initializer
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:2239: warning: missing braces around initializer
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:2239: warning: (near initialization for 'drop_rrp.<anonymous>')
> 
> gcc-4.4.4 has issues with anonymous union initializers.  Work around this.
> 
> Cc: Saeed Mahameed <saeedm@...lanox.com>
> Cc: Tariq Toukan <tariqt@...lanox.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

Applied.