netdev - Re: [PATCH] net: ethernet: ti: cpsw: wake tx queues on ndo_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170402.194306.1830349337879774492.davem@davemloft.net>
Date:   Sun, 02 Apr 2017 19:43:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     grygorii.strashko@...com
Cc:     netdev@...r.kernel.org, nsekhar@...com,
        linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
        ivan.khoronzhuk@...aro.org
Subject: Re: [PATCH] net: ethernet: ti: cpsw: wake tx queues on
 ndo_tx_timeout

From: Grygorii Strashko <grygorii.strashko@...com>
Date: Fri, 31 Mar 2017 18:41:23 -0500

> In case, if TX watchdog is fired some or all netdev TX queues will be
> stopped and as part of recovery it is required not only to drain and
> reinitailize CPSW TX channeles, but also wake up stoppted TX queues what
> doesn't happen now and netdevice will stop transmiting data until
> reopenned.
> 
> Hence, add netif_tx_wake_all_queues() call in .ndo_tx_timeout() to complete
> recovery and restore TX path.
> 
> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>

Applied, thank you.