lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 3 Apr 2017 08:23:23 -0500 From: Rob Herring <robh@...nel.org> To: Stefan Wahren <stefan.wahren@...e.com> Cc: Mark Rutland <mark.rutland@....com>, "David S. Miller" <davem@...emloft.net>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jslaby@...e.com>, Marcel Holtmann <marcel@...tmann.org>, Sebastian Reichel <sre@...nel.org>, netdev <netdev@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH RFC v4 07/10] dt-bindings: net: add binding for QCA7000 UART On Tue, Mar 28, 2017 at 06:18:03PM +0200, Stefan Wahren wrote: > Am 27.03.2017 um 22:30 schrieb Rob Herring: > > On Mon, Mar 27, 2017 at 8:37 AM, Stefan Wahren <stefan.wahren@...e.com> wrote: > >> This is the serdev binding for the QCA7000 UART driver (Ethernet over UART). > >> > >> Signed-off-by: Stefan Wahren <stefan.wahren@...e.com> > >> --- > >> > >> According to this binding are still some questions: > >> > >> Where should be the optional hardware flow control defined (at master or slave side)? > > Probably should be in the slave side. We already have uart-has-rtscts > > and rts/cts-gpios for the UART. Those mean we have RTS/CTS, but not > > necessarily that we want to enable them. > > > > In many cases, the driver may know what it needs. > > Like all the other UART settings the hardware flow control can be > configured in the QCA7000 firmware and the driver can't detect it. > > Property suggestion for the slave side: > > use-rtscts Okay. > >> Is it okay to have two bindings (qca-qca7000-spi and qca-qca7000-uart) or should they be merged? > > Are they mutually-exclusive or both are used at the same time? > > They are mutually-exclusive because they use the same pins. > > > What > > are the dependencies between the interfaces? > > Except they uses the same pins of the QCA7000, i can't see any dependency. I think they should be a single doc. Rob
Powered by blists - more mailing lists