netdev - Re: [PATCH] net: ibm: emac: remove unused sysrq handler for 'c' key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170405.072636.1936712503456383299.davem@davemloft.net>
Date:   Wed, 05 Apr 2017 07:26:36 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ebiggers3@...il.com
Cc:     netdev@...r.kernel.org, ivan@...ibm.com,
        linux-kernel@...r.kernel.org, ebiggers@...gle.com
Subject: Re: [PATCH] net: ibm: emac: remove unused sysrq handler for 'c' key

From: Eric Biggers <ebiggers3@...il.com>
Date: Mon,  3 Apr 2017 22:50:20 -0700

> From: Eric Biggers <ebiggers@...gle.com>
> 
> Since commit d6580a9f1523 ("kexec: sysrq: simplify sysrq-c handler"),
> the sysrq handler for the 'c' key has been sysrq_crash_op.  Debugging
> code in the ibm_emac driver also tries to register a handler for the 'c'
> key, but this has no effect because register_sysrq_key() doesn't replace
> existing handlers.  Since evidently no one has cared enough to fix this
> in the last 8 years, and it's very rare for drivers to register sysrq
> handlers (for good reason), just remove the dead code.
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Applied to net-next, thanks.